- DRM_DEV_DEBUG_DRIVER(dev, "found dsi host node.\n");
- bus_type = V4L2_FWNODE_BUS_TYPE_PARALLEL;
- mipi_lanes = MAX_LANES_SUPPORT;
- ep0 = of_graph_get_endpoint_by_regs(np, 0, 0);
- if (ep0) {
if (of_property_read_u32(ep0, "bus-type", &bus_type))bus_type = 0;mipi_lanes = of_property_count_u32_elems(ep0, "data-lanes");- }
- if (bus_type == V4L2_FWNODE_BUS_TYPE_PARALLEL) /* bus type is Parallel(DSI) */
This is not correct *at all*. V4L2_FWNODE_BUS_TYPE_PARALLEL has nothing to do with DSI. DSI stands for Digital *Serial* Interface. If anything, the V4L2_FWNODE_BUS_TYPE_PARALLEL type would map better to DPI, even if it's not an exact match.
This patch has landed in v5.17-rc1, along with the corresponding bindings. As DT bindings are an ABI, we should really fix this before v5.17 is released. There is no DSI bus types defined in DT, and adding one as a fix so late in the v5.17-rc cycle seems a bit of a stretch to me (unless Rob disagrees).
It would seem best to revert this series and the corresponding bindings, and retry in v5.18.
There is a DT patch using this property that is already queued up for 5.17 in the soc tree:
https://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kerne...
merged here:
https://nam10.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit.kernel....
We will need to revert that one as well.
I just submitted a series reverting the dt-binding change + the related commit to "mt8183: jacuzzi". Can I get a quick r-b/a-b in order to get this into v5.17.
https://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kerne...
v2 of revert submitted.
https://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kerne...
Xin: Will you spin a series that adds DPI support and re-enables DPI for anx7625? Additionally, "mt8183: jacuzzi" will have to have DPI re-enabled.
Hi Robert Foss, I'm little confused, do I need resend this serial or send a patch based on currently define(V4L2_FWNODE_BUS_TYPE_PARALLEL)?
And use V4L2_FWNODE_BUS_TYPE_PARALLEL for DPI, other value for DSI setup?
V4L2_FWNODE_BUS_TYPE_PARALLEL is not meant to be used for DPI, but rather is used to represtent CPI. So another enum (something along the lines of V4L2_FWNODE_BUS_TYPE_DPI) needs to be defined, and then this series needs to use this new enum.
I'd like to see the following: - Introduction of V4L2_FWNODE_BUS_TYPE_DPI - Reworking this series to use V4L2_FWNODE_BUS_TYPE_DPI - Reworking "mt8183: jacuzzi" to use V4L2_FWNODE_BUS_TYPE_DPI
Does that make sense?
Rob.