Re: [PATCH v3] drm/exynos: Remove dev_err() on platform_get_irq() failure

20. 5. 21. 오후 11:22에 Tamseel Shams 이(가) 쓴 글:

platform_get_irq() will call dev_err() itself on failure, so there is no need for the driver to also do this. This is detected by coccinelle.

Picked it up.

Thanks, Inki Dae

Signed-off-by: Tamseel Shams m.shams@samsung.com

• Changes since v2:

• Addressed Inki Dae comments

drivers/gpu/drm/exynos/exynos_drm_g2d.c | 1 - 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/exynos/exynos_drm_g2d.c index fcee33a43aca..03be31427181 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_g2d.c +++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.c @@ -1498,7 +1498,6 @@ static int g2d_probe(struct platform_device *pdev)

g2d->irq = platform_get_irq(pdev, 0); if (g2d->irq < 0) {

• dev_err(dev, "failed to get irq\n");
  

  ret = g2d->irq; goto err_put_clk; }