Hi Maxime,
I love your patch! Perhaps something to improve:
[auto build test WARNING on drm/drm-next] [also build test WARNING on drm-intel/for-linux-next drm-tip/drm-tip v5.17 next-20220325] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Maxime-Ripard/drm-atomic-Atomic-Pri... base: git://anongit.freedesktop.org/drm/drm drm-next config: ia64-defconfig (https://download.01.org/0day-ci/archive/20220326/202203260001.Gfx0MJJ4-lkp@i...) compiler: ia64-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/dc4288c88376cba127b0280246b77566b18d... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Maxime-Ripard/drm-atomic-Atomic-Private-State-debugging/20220325-205019 git checkout dc4288c88376cba127b0280246b77566b18d9f1d # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=ia64 SHELL=/bin/bash drivers/gpu/drm/
If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot lkp@intel.com
All warnings (new ones prefixed by >>):
drivers/gpu/drm/drm_atomic.c: In function 'drm_atomic_print_new_state':
drivers/gpu/drm/drm_atomic.c:1670:33: warning: variable 'obj' set but not used [-Wunused-but-set-variable]
1670 | struct drm_private_obj *obj; | ^~~
vim +/obj +1670 drivers/gpu/drm/drm_atomic.c
1649 1650 /** 1651 * drm_atomic_print_new_state - prints drm atomic state 1652 * @state: atomic configuration to check 1653 * @p: drm printer 1654 * 1655 * This functions prints the drm atomic state snapshot using the drm printer 1656 * which is passed to it. This snapshot can be used for debugging purposes. 1657 * 1658 * Note that this function looks into the new state objects and hence its not 1659 * safe to be used after the call to drm_atomic_helper_commit_hw_done(). 1660 */ 1661 void drm_atomic_print_new_state(const struct drm_atomic_state *state, 1662 struct drm_printer *p) 1663 { 1664 struct drm_plane *plane; 1665 struct drm_plane_state *plane_state; 1666 struct drm_crtc *crtc; 1667 struct drm_crtc_state *crtc_state; 1668 struct drm_connector *connector; 1669 struct drm_connector_state *connector_state;
1670 struct drm_private_obj *obj;
1671 struct drm_private_state *obj_state; 1672 int i; 1673 1674 if (!p) { 1675 drm_err(state->dev, "invalid drm printer\n"); 1676 return; 1677 } 1678 1679 drm_dbg_atomic(state->dev, "checking %p\n", state); 1680 1681 for_each_new_plane_in_state(state, plane, plane_state, i) 1682 drm_atomic_plane_print_state(p, plane_state); 1683 1684 for_each_new_crtc_in_state(state, crtc, crtc_state, i) 1685 drm_atomic_crtc_print_state(p, crtc_state); 1686 1687 for_each_new_connector_in_state(state, connector, connector_state, i) 1688 drm_atomic_connector_print_state(p, connector_state); 1689 1690 for_each_new_private_obj_in_state(state, obj, obj_state, i) 1691 drm_atomic_private_obj_print_state(p, obj_state); 1692 } 1693 EXPORT_SYMBOL(drm_atomic_print_new_state); 1694