Re: [PATCH 3/6] dma-buf: Add ioctls to allow userspace to flush

On Wed, Aug 26, 2015 at 08:29:15PM -0300, Tiago Vignatti wrote:

+#ifndef _DMA_BUF_UAPI_H_ +#define _DMA_BUF_UAPI_H_

+enum dma_buf_sync_flags {

• DMA_BUF_SYNC_READ = (1 << 0),
• DMA_BUF_SYNC_WRITE = (2 << 0),
• DMA_BUF_SYNC_RW = (3 << 0),
• DMA_BUF_SYNC_START = (0 << 2),
• DMA_BUF_SYNC_END = (1 << 2),
• DMA_BUF_SYNC_VALID_FLAGS_MASK = DMA_BUF_SYNC_RW |

• DMA_BUF_SYNC_END
  

+};

+/* begin/end dma-buf functions used for userspace mmap. */ +struct dma_buf_sync {

• enum dma_buf_sync_flags flags;

It is better to use explicitly sized types. And since this is not 64b padded, probably best to add that padding now. -Chris