Hi allen,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linus/master] [also build test WARNING on v5.4-rc5 next-20191031] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/allen/drm-edid-fixup-EDID-1-3-and-1... base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 1204c70d9dcba31164f78ad5d8c88c42335d51f8
If you fix the issue, kindly add following tag Reported-by: kbuild test robot lkp@intel.com
smatch warnings: drivers/gpu/drm/drm_edid.c:2042 drm_monitor_supports_rb() warn: always true condition '(closure.support_rb >= 0) => (0-255 >= 0)'
vim +2042 drivers/gpu/drm/drm_edid.c
2030 2031 /* EDID 1.4 defines this explicitly. For EDID 1.3, we guess, badly. */ 2032 static bool 2033 drm_monitor_supports_rb(struct edid *edid) 2034 { 2035 struct edid_support_rb_closure closure = { 2036 .edid = edid, 2037 .support_rb = -1, 2038 }; 2039 2040 if (edid->revision >= 4) { 2041 drm_for_each_detailed_block((u8 *)edid, is_rb, &closure);
2042 if (closure.support_rb >= 0)
2043 return closure.support_rb; 2044 } 2045 2046 return true; 2047 } 2048
--- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation