On Tue, Jun 21, 2022 at 12:06 AM José Expósito jose.exposito89@gmail.com wrote:
Explain how to run the KUnit tests present in the DRM subsystem and clarify why the UML-only options were not added to the configuration file present in drivers/gpu/drm/.kunitconfig [1] [2].
[1] https://lore.kernel.org/dri-devel/CABVgOSn8i=LO5p7830h2XU1Jgg0KrN0qTnxkOMhf1... [2] https://lore.kernel.org/dri-devel/CAGS_qxqpiCim_sy1LDK7PLwVgWf-LKW+uNFTGM=T7...
Reviewed-by: Maxime Ripard maxime@cerno.tech Reviewed-by: Javier Martinez Canillas javierm@redhat.com Acked-by: Thomas Zimmermann tzimmermann@suse.de Signed-off-by: José Expósito jose.exposito89@gmail.com
This looks good (and doesn't seem to introduce any 'make htmldocs' build issues on my machine).
You could also mention that using --arch=x86_64 (or similar) instead of the UML options is another, equally viable option for running the tests. That'd make it more obvious how to run on different architectures: UML, while a good default, is quite different to other architectures in not having any PCI support out-of-the-box.
(Maybe we should make the --arch=um default config include these options? Or have um-pci as another architecture. We did decide not to bother with SMP and x86, though...)
Regardless, this is Reviewed-by: David Gow davidgow@google.com
Cheers, -- David