Re: [PATCH] drm/vmwgfx: Propagate error on failed ioctl

Hello Philipp,

On 3/13/22 06:06, Philipp Sieweck wrote:

The cases of vmw_user_bo_synccpu_grab failing with -ERESTARTSYS or -EBUSY are handled in vmw_user_bo_synccpu_ioctl by not printing an error message. However, the error value gets discarded, indicating success. This leads to rendering glitches and a reported drm error on the next ioctl call to release the handle.

This patch propagates the error value from vmw_user_synccpu_grab.

Signed-off-by: Philipp Sieweck psi@informatik.uni-kiel.de

drivers/gpu/drm/vmwgfx/vmwgfx_bo.c | 2 ++ 1 file changed, 2 insertions(+)

Patch looks good to me.

Reviewed-by: Javier Martinez Canillas javierm@redhat.com