Remove unnecessary variable _misc_ and refactor the code.
A value is assigned to variable _misc_ at lines 1002 and 1004 and then overwritten at line 1127, just before it can be used. Besides, this variable is only being used as an argument when calling macro WREG8() and, it is not implied in any other operation.
Addresses-Coverity-ID: 1397681 Signed-off-by: Gustavo A. R. Silva garsilva@embeddedor.com --- drivers/gpu/drm/mgag200/mgag200_mode.c | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag200/mgag200_mode.c index adb411a..960e43b 100644 --- a/drivers/gpu/drm/mgag200/mgag200_mode.c +++ b/drivers/gpu/drm/mgag200/mgag200_mode.c @@ -923,7 +923,6 @@ static int mga_crtc_mode_set(struct drm_crtc *crtc, int pitch; int option = 0, option2 = 0; int i; - unsigned char misc = 0; unsigned char ext_vga[6]; u8 bppshift;
@@ -998,11 +997,6 @@ static int mga_crtc_mode_set(struct drm_crtc *crtc, break; }
- if (mode->flags & DRM_MODE_FLAG_NHSYNC) - misc |= 0x40; - if (mode->flags & DRM_MODE_FLAG_NVSYNC) - misc |= 0x80; -
for (i = 0; i < sizeof(dacvalue); i++) { if ((i <= 0x17) || @@ -1124,8 +1118,7 @@ static int mga_crtc_mode_set(struct drm_crtc *crtc, ext_vga[1] |= 0x88;
/* Set pixel clocks */ - misc = 0x2d; - WREG8(MGA_MISC_OUT, misc); + WREG8(MGA_MISC_OUT, 0x2d);
mga_crtc_set_plls(mdev, mode->clock);
@@ -1145,9 +1138,7 @@ static int mga_crtc_mode_set(struct drm_crtc *crtc,
WREG_ECRT(0, ext_vga[0]); /* Enable mga pixel clock */ - misc = 0x2d; - - WREG8(MGA_MISC_OUT, misc); + WREG8(MGA_MISC_OUT, 0x2d);
if (adjusted_mode) memcpy(&mdev->mode, mode, sizeof(struct drm_display_mode));