Re: [PATCH v2] drm/exynos: calculate vrefresh instead of use a fixed value

2015-05-20 Tobias Jakobi tjakobi@math.uni-bielefeld.de:

Gustavo Padovan wrote:

...

From: Gustavo Padovan gustavo.padovan@collabora.co.uk

When mode's vrefresh is zero we should ask DRM core to calculate vrefresh for us so we can get the correct value instead of relying on fixed value defined in a macro. But if vrefresh is still zero we should fail the update.

Even with this we still need to consider crtc->state->adjusted_mode in fimd_commit(), otherwise vrefresh computed by drm_mode_vrefresh() is never actually used.

You are right, I think we should pass crtc->state->adjusted_mode to fimd_calc_clkdiv(). I'll send a v3 with this change.

Gustavo