Acked-by: Bas Nieuwenhuizen bas@basnieuwenhuizen.nl
Didn't test the latest version of everything, but I can confirm the UAPI worked fine for what we'd want to use it for with radv.
On Thu, May 26, 2022 at 8:47 AM Jason Ekstrand jason@jlekstrand.net wrote:
On Wed, May 25, 2022 at 5:02 AM Daniel Stone daniel@fooishbar.org wrote:
On Sat, 7 May 2022 at 14:18, Jason Ekstrand jason@jlekstrand.net wrote:
This patch series actually contains two new ioctls. There is the export one mentioned above as well as an RFC for an import ioctl which provides the other half. The intention is to land the export ioctl since it seems like there's no real disagreement on that one. The import ioctl, however, has a lot of debate around it so it's intended to be RFC-only for now.
Errr, I think we're good with this one now right?
Yeah, I dropped the RFC from the patch, just not the description in the cover letter, apparently.
From the uAPI point of view, having looked through the Mesa MR, both are: Acked-by: Daniel Stone daniels@collabora.com
For reference: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4037
Yes, I agree it's gotten sufficient review at this point that I think we can call the uAPI reviewed. I'm good with landing now. Sorry that took so long but the original version I had only used half of the new API and I wanted to make sure both halves got good testing.
--Jason
Cheers, Daniel