Re: [PATCH 1/3] drm/exynos: Drop useless check from exynos_drm_{suspend,resume}

2018년 06월 11일 21:24에 Marek Szyprowski 이(가) 쓴 글:

The virtual Exynos DRM device has no runtime PM enabled, so checking for its runtime suspended state is useless.

Signed-off-by: Marek Szyprowski m.szyprowski@samsung.com

drivers/gpu/drm/exynos/exynos_drm_drv.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c index a81b4a5e24a7..c0b4a03ae1b6 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_drv.c +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c @@ -153,7 +153,7 @@ static int exynos_drm_suspend(struct device *dev) struct drm_device *drm_dev = dev_get_drvdata(dev); struct exynos_drm_private *private;

• if (pm_runtime_suspended(dev) || !drm_dev)

• if (!drm_dev) return 0;

  private = drm_dev->dev_private;

@@ -175,8 +175,8 @@ static int exynos_drm_resume(struct device *dev) struct drm_device *drm_dev = dev_get_drvdata(dev); struct exynos_drm_private *private;

• if (pm_runtime_suspended(dev) || !drm_dev)

• return 0;
  

• if (!drm_dev)

• return;
  

return 0. I will fix it.

Thanks, Inki Dae

private = drm_dev->dev_private; drm_atomic_helper_resume(drm_dev, private->suspend_state);