On Fri, Dec 22, 2017 at 4:56 AM, Alexandre Belloni alexandre.belloni@free-electrons.com wrote:
- Philippe
On 22/12/2017 at 11:43:33 +0100, Andreas Färber wrote:
I'll change it for v3 of this patch however it will end up like this: //SPDX-License...
That should be /* SPDX-License */, // is for c files.
Got any reference for that? Since we're using the C preprocessor before feeding them to dtc, we can use the same // style for both, builds fine.
Only for my private DT overlay files that I use directly with dtc I couldn't adopt that style.
We are well past the point of being able to build most dts files with just dtc.
The doc states:
If a specific tool cannot handle the standard comment style, then the appropriate comment mechanism which the tool accepts shall be used. This is the reason for having the "/* */" style comment in C header files.
I interpreted that as dtc doesn't handle // comments, use /**/
It's been so long, I'd forgotten that. Perhaps we should fix dtc to handle // comments.
But I agree it also states: .dts{i}: // SPDX-License-Identifier: <SPDX License Expression>
Or we could still change this. The guidelines aren't merged yet.
Rob