Re: [[Intel-gfx] [PATCH v2 00/10] drm: Introduce struct drm_device based WARN* and use them in i915

On Thu, Jan 23, 2020 at 11:39:37AM +0200, Jani Nikula wrote:

On Thu, 23 Jan 2020, "Bharadiya,Pankaj" pankaj.laxminarayan.bharadiya@intel.com wrote:

...

Will rebase remaining patches and submit.

Please also add a patch to convert MISSING_CASE(),

Will do.

and another to remove the WARN_ON/WARN_ON_ONCE "overrides" that we have in i915_utils.h.

Still i915 driver wil have many calls to WARN_ON* after this patch series gets merged.

Shall I remove WARN_ON/WARN_ON_ONCE "overrides" so that existing callers will fallback to original WARN_ON* implementation until complete conversion is done? Just want to double confirm on this before I submit a patch.

Thanks, Pankaj

Thanks, Jani.

-- Jani Nikula, Intel Open Source Graphics Center