On Mon, 2020-10-05 at 21:50 -0700, Randy Dunlap wrote:
From: Randy Dunlap rdunlap@infradead.org
arch/arc/ implements BUG_ON() with BUG(). ARC has its own BUG() function and that function uses pr_warn() as part of its implementation.
Several (8) files in amd/powerplay/ #undef various pr_xyz() functions so that they won't be used by these drivers, since dev_() functions are preferred here and the #undefs make the pr_() functions unavailable.
[]
--- lnx-59-rc7.orig/drivers/gpu/drm/amd/powerplay/navi10_ppt.c +++ lnx-59-rc7/drivers/gpu/drm/amd/powerplay/navi10_ppt.c @@ -52,7 +52,7 @@
- They are more MGPU friendly.
*/ #undef pr_err -#undef pr_warn +//#undef pr_warn #undef pr_info #undef pr_debug
--- lnx-59-rc7.orig/drivers/gpu/drm/amd/powerplay/sienna_cichlid_ppt.c +++ lnx-59-rc7/drivers/gpu/drm/amd/powerplay/sienna_cichlid_ppt.c @@ -54,7 +54,7 @@
- They are more MGPU friendly.
*/ #undef pr_err -#undef pr_warn +//#undef pr_warn #undef pr_info #undef pr_debug
These are bad ideas as all of these pr_<level> entries may become functions in a near-term future.