On 18 March 2015 at 01:19, Chih-Wei Huang cwhuang@android-x86.org wrote:
2015-03-18 7:30 GMT+08:00 Emil Velikov emil.l.velikov@gmail.com:
As pointed out by Chih-Wei, Android's LOCAL_COPY_HEADERS{,_TO} has been depreciated for quite some time.
Although it was a convenient way of getting things done (no more hard-coding the location of drm) it seems that there is another more appropriate (and cleaner) solution. Namely: Annotate the includes as "exported" and as the user selects the library for linking, the build will automatically add the includes.
Big thanks to Chih-Wei for the patience and persistence explaining the whole shebang. This series is mostly based on his patch in the Android-x86 tree, with some extra bits from your truly :-)
Chih-Wei,
I've tested this a few times already, although having someone with experience in the whole thing will be appreciated.
Thank you for the effort to clean it up. The patches looks good to me.
I would suggest to remove all the use of LIBDRM_TOP. Do you want me to submit a patch?
Hmm I'm not sure that things will work correctly if we directly substitute LIBDRM_TOP with LOCAL_PATH within the following.
mkfiles := $(patsubst %,$(LIBDRM_TOP)/%/Android.mk,$(SUBDIRS))
Can you send a patch over ?
Thanks Emil