Hi Rajat,
On Tue, Dec 21, 2021 at 04:11:26PM -0800, Rajat Jain wrote:
+static int chromeos_privacy_screen_remove(struct acpi_device *adev) +{
- struct drm_privacy_screen *drm_privacy_screen = acpi_driver_data(adev);
Please add an empty line here:
WARNING: Missing a blank line after declarations #292: FILE: drivers/platform/chrome/chromeos_privacy_screen.c:129: + struct drm_privacy_screen *drm_privacy_screen = acpi_driver_data(adev); + drm_privacy_screen_unregister(drm_privacy_screen);
- drm_privacy_screen_unregister(drm_privacy_screen);
- return 0;
+}
+static const struct acpi_device_id chromeos_privacy_screen_device_ids[] = {
- {"GOOG0010", 0}, /* Google's electronic privacy screen for eDP-1 */
- {}
+}; +MODULE_DEVICE_TABLE(acpi, chromeos_privacy_screen_device_ids);
+static struct acpi_driver chromeos_privacy_screen_driver = {
- .name = "chromeos_privacy_screen_drvr",
Could I buy 2 move vowels? ;)
- .class = "ChromeOS",
- .ids = chromeos_privacy_screen_device_ids,
- .ops = {
.add = chromeos_privacy_screen_add,.remove = chromeos_privacy_screen_remove,- },
+};
+module_acpi_driver(chromeos_privacy_screen_driver); +MODULE_LICENSE("GPL v2"); +MODULE_DESCRIPTION("ChromeOS ACPI Privacy Screen driver"); +MODULE_AUTHOR("Rajat Jain rajatja@google.com");
Otherwise
Reviewed-by: Dmitry Torokhov dmitry.torokhov@gmail.com
Thanks.