On 2018-01-03 12:11 PM, Carlo Caione wrote:
From: Carlo Caione carlo@endlessm.com
Hi, on several laptops [0] we are seeing display corruption when using multiple / external displays. We already opened an issue upstream [1]. The following 4 patches are taken from agd5f/amd-staging-drm-next and they seem able to solve the issue. Can those be included in 4.15?
Thank you,
[0] Acer Aspire E5-553G (AMD FX-9800P RADEON R7) Acer Aspire E5-523G (AMD E2-9010 RADEON R2) Acer Aspire A315-21 (AMD A4-9120 RADEON R3) Acer Aspire A515-41G (AMD A10-9620 RADEON R5)
[1] https://bugs.freedesktop.org/show_bug.cgi?id=104319
Harry Wentland (1): drm/amd/display: Both timing_sync and multisync need stream_count > 1
Leo (Sunpeng) Li (1): drm/amd/display: Change frontend/backend programming sequence
Mikita Lipski (2): drm/amd/display: Adding DCN1 registers drm/amd/display: Multi display synchronization logic
I'm surprised Mikita and my patches are required here. Are you sure they make a difference for display corruption or did you simply add them to make pull Leo's patch more cleanly?
They're not bad changes. The "Multi display synchronization logic" patch is just very big and shouldn't have an impact expect in very unique situations.
Harry
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 54 ++++- drivers/gpu/drm/amd/display/dc/core/dc.c | 60 ++++- drivers/gpu/drm/amd/display/dc/dc.h | 3 + drivers/gpu/drm/amd/display/dc/dc_hw_types.h | 16 ++ .../amd/display/dc/dce110/dce110_hw_sequencer.c | 46 +++- .../display/dc/dce110/dce110_timing_generator.c | 265 +++++++++++++++++---- .../display/dc/dce110/dce110_timing_generator.h | 6 + .../drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 29 ++- .../amd/display/dc/dcn10/dcn10_timing_generator.c | 66 ++++- .../amd/display/dc/dcn10/dcn10_timing_generator.h | 33 ++- .../drm/amd/display/dc/inc/hw/timing_generator.h | 6 +- drivers/gpu/drm/amd/display/dc/inc/hw_sequencer.h | 5 + 12 files changed, 511 insertions(+), 78 deletions(-)