On 10/1/19 17:21, Liu, Leo wrote:
OK. So, maybe we can add a comment pointing that out?
That could be better.
Great. I'm glad it's not a bug. I'll write a patch for that so other people don't waste time taking a look.
Thanks, just sent two patches to add comment, and long with the patch to make VCN ring ready properly.
Awesome. Thank you. I would just add a commit log to this patch:
[PATCH 2/2] drm/amdgpu: add a comment to VCN 2.5 encode ring
I'd update the subject to: drm/amdgpu: add code comment in vcn_v2_5_hw_init and add this as a commit log: Add a comment to VCN 2.5 encode ring
Also, I think it's important to follow the process and CC all the people and lists below:
$ scripts/get_maintainer.pl --nokeywords --nogit --nogit-fallback drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c Alex Deucher alexander.deucher@amd.com (supporter:RADEON and AMDGPU DRM DRIVERS) "Christian König" christian.koenig@amd.com (supporter:RADEON and AMDGPU DRM DRIVERS) "David (ChunMing) Zhou" David1.Zhou@amd.com (supporter:RADEON and AMDGPU DRM DRIVERS) David Airlie airlied@linux.ie (maintainer:DRM DRIVERS) Daniel Vetter daniel@ffwll.ch (maintainer:DRM DRIVERS) amd-gfx@lists.freedesktop.org (open list:RADEON and AMDGPU DRM DRIVERS) dri-devel@lists.freedesktop.org (open list:DRM DRIVERS) linux-kernel@vger.kernel.org (open list)
Thanks -- Gustavo