20 Jan
2015
20 Jan
'15
8:49 p.m.
On 01/20/2015 12:35 PM, Ian Romanick wrote:
On 01/19/2015 03:00 AM, Chris Wilson wrote:
DRI2Buffer *buffers;for (i = 0; i < priv->bufferCount; i++)attachments[i] = priv->buffers[i].attachment;buffers = DRI2GetBuffers(priv->base.psc->dpy, priv->base.xDrawable,&priv->width, &priv->height,attachments, i, &i);Most drivers prefer DRI2GetBuffersWithFormat, and some drivers only use DRI2GetBuffersWithFormat. Is mixing DRI2GetBuffersWithFormat and DRI2GetBuffers going to cause problems or unexpected behavior changes?
Okay... I hadn't seen the server change until after I sent this review. I sent some comments there.
This should be fine, but can we get a comment that it relies on DRI2GetBuffers re-using the format from the previous DRI2GetBuffersWithFormat? That way the next person to look at the code won't make the same mistake I made.