3 May
2017
3 May
'17
4:03 p.m.
Lucas Stach l.stach@pengutronix.de writes:
Hi Eric,
Am Mittwoch, den 12.04.2017, 12:12 -0700 schrieb Eric Anholt:
If we follow the typical pattern of the base class being the first member, we can use the default dma_fence_free function.
Sorry, I don't like this change. While it provides a bit of code simplification, it also bakes the implicit assumption into the code that dma_fence is the first struct member without any checks to validate this assumption. I would at least expect a build bug assert, but then the current bit of code to keep this explicit and self-documenting is probably just as good.
Fine with me. Please make sure you grab patch 2, though.