On Tue, Jul 19, 2011 at 3:57 AM, Alan Cox alan@lxorguk.ukuu.org.uk wrote:
On Mon, 18 Jul 2011 19:20:56 -0500 Rob Clark rob@ti.com wrote:
In the process of adding GEM support for OMAP DRM driver, I noticed that I was adding code for creating/freeing mmap offsets which was virtually identical to what was already duplicated in i915 and gma500 drivers.
The gma500 one was taken from i915 and I'd reach the same conclusion as you - the current GMA500 driver (see staging git) has the mmap offset patches broken out in gem_glue.c ready to do what you are proposing.
ahh, ok.. I should check this out (although I'm not entirely sure where your gma500 staging tree is)
I'm already using your patch to add drm_gem_private_object_init() for scanout buffers (which need to be physically contiguous). But perhaps you have some other useful "gems"
BR, -R
Rather than duplicating the code a 3rd time, it seemed like a good idea to move it to the GEM core.
Agreed entirely.
Note that I don't actually have a way to test psb or i915, but the changes seem straightforward enough.
Your patch doesn't apply versus gma500 but its trivial to remove it from gem_glue.c once it goes into the mainstream GEM.
(The other bits in the gma500 glue are to allow for GEM objects backed by things other than shmfs)
Alan _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel