9 Oct
2020
9 Oct
'20
2:39 p.m.
On Fri, Oct 09, 2020 at 04:29:55PM +0200, Christian König wrote:
- entity = kcalloc(1, offsetof(typeof(*entity), fences[amdgpu_sched_jobs]),
- entity = kmalloc(struct_size(entity, fences, amdgpu_sched_jobs),
NAK. You could use kzalloc() here, but kmalloc won't zero initialize the memory which could result in unforeseen consequences.
Oh I see.. I certainly didn't take that into account.
I'll fix that up and respin.
Shit happens, we already have a fix for this. Alex merged it and it immediately broke our testing systems.
:/
So one of our engineers came up with a fix which should already have been applied.
Great. Good to know it's already fixed! :)
Thanks -- Gustavo