On Wed, May 13, 2020 at 10:43:51PM +0100, Emil Velikov wrote:
With earlier commits, the API no longer discards the const-ness of the sysrq_key_op. As such we can add the notation.
Cc: Greg Kroah-Hartman gregkh@linuxfoundation.org Cc: Jiri Slaby jslaby@suse.com Cc: linux-kernel@vger.kernel.org Cc: "Paul E. McKenney" paulmck@kernel.org Cc: Josh Triplett josh@joshtriplett.org Cc: rcu@vger.kernel.org Signed-off-by: Emil Velikov emil.l.velikov@gmail.com
Please keep me in the CC list, as I'm not subscribed to the list.
IMHO it would be better if this gets merged this via the tty tree.
Works for me:
Reviewed-by: Paul E. McKenney paulmck@kernel.org
kernel/rcu/tree_stall.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/rcu/tree_stall.h b/kernel/rcu/tree_stall.h index 119ed6afd20f..4e6ed7b91f59 100644 --- a/kernel/rcu/tree_stall.h +++ b/kernel/rcu/tree_stall.h @@ -729,7 +729,7 @@ static void sysrq_show_rcu(int key) show_rcu_gp_kthreads(); }
-static struct sysrq_key_op sysrq_rcudump_op = { +static const struct sysrq_key_op sysrq_rcudump_op = { .handler = sysrq_show_rcu, .help_msg = "show-rcu(y)", .action_msg = "Show RCU tree", -- 2.25.1