Re: [PATCH 7/9] drm/edid: Expose mandatory stereo modes for HDMI sinks

Damien Lespiau <damien.lespiau <at> intel.com> writes:

+static const struct s3d_mandatory_mode s3d_mandatory_modes[] = {

• { 1920, 1080, 24, 0,

•  DRM_MODE_FLAG_3D_TOP_AND_BOTTOM | DRM_MODE_FLAG_3D_FRAME_PACKING 
  

},

• { 1920, 1080, 50, DRM_MODE_FLAG_INTERLACE,

•  DRM_MODE_FLAG_3D_SIDE_BY_SIDE_HALF },
  

• { 1920, 1080, 60, DRM_MODE_FLAG_INTERLACE,

•  DRM_MODE_FLAG_3D_SIDE_BY_SIDE_HALF },
  

• { 1280, 720, 50, 0,

•  DRM_MODE_FLAG_3D_TOP_AND_BOTTOM | DRM_MODE_FLAG_3D_FRAME_PACKING 
  

},

• { 1280, 720, 60, 0,

•  DRM_MODE_FLAG_3D_TOP_AND_BOTTOM | DRM_MODE_FLAG_3D_FRAME_PACKING }
  

+};

I may be missing something here... But..

The frame packed modes are much higher in pixels than this and include frame packing. 1080*2+45=2050 720*2+30=1470

Unless you intend to hide the left/right split in mesa or other place, we need to get the ability to render to both fields somehow.

Either as the full 2050 pixels high or at 1080*2 and the driver adds the blanking.

Also, some logic aught to indicate pixel aspect ratio for the modes since they are non square for the half res modes.

/Joakim