On Mon, Sep 22, 2014 at 06:12:41PM +0800, Daniel Kurtz wrote:
On Mon, Sep 22, 2014 at 4:39 PM, Thierry Reding thierry.reding@gmail.com wrote:
On Tue, Sep 02, 2014 at 10:56:46AM +0800, Daniel Kurtz wrote:
There are several different models of N116BGE. According to the commit that added innolux_n116bge_mode [0], this N116BGE is for the eDP variety.
[0] commit 0a2288c06aab73c966e82045c8f20b0e713baf2a Author: Thierry Reding treding@nvidia.com Date: Thu Jul 3 14:02:59 2014 +0200
drm/panel: simple: Add Innolux N116BGE panel support
The clock and htotal values from add by that patch are out of spec according to the datasheets I have seen for the eDP N116BGE (-EA2 and -EB2).
Does out of spec imply that these timings aren't working for you?
No, I didn't even try with your values, actually. Out of spec just means that the numbers do not fall between Min and Max on the datasheet:
72.6 <= DCLK <= 80.24 vs. 71 1506 <= htotal <= 1716 vs. 1500
This patch changes the values to the "Typ" values on the datasheet.
The original patch was based on -E42 of the datasheet. But I can run some tests to see if the timings in this patch work on the panel that I have. If so I guess the easiest would be to apply this.
Thanks!
Took me a while longer to test this than I had expected. Turns out the Tegra132 Norrin board that I have works with the timings you provide in this patch too, so I'm going to apply this patch.
Thierry