On Mon, Nov 15, 2021 at 09:35:09AM +0100, Geert Uytterhoeven wrote:
On Mon, Nov 15, 2021 at 7:33 AM Randy Dunlap rdunlap@infradead.org wrote:
Fix fallthrough warnings in sh776fb.c:
../drivers/video/fbdev/sh7760fb.c: In function 'sh7760fb_get_color_info': ../drivers/video/fbdev/sh7760fb.c:138:23: warning: this statement may fall through [-Wimplicit-fallthrough=] 138 | lgray = 1; ../drivers/video/fbdev/sh7760fb.c:143:23: warning: this statement may fall through [-Wimplicit-fallthrough=] 143 | lgray = 1;
Just document the current state of code execution/flow.
Fixes: 4a25e41831ee ("video: sh7760fb: SH7760/SH7763 LCDC framebuffer driver") Signed-off-by: Randy Dunlap rdunlap@infradead.org
Section 30.4.4 ("Data Format") of the SH7760 Group Hardware Manual confirms fall-through is appropriate here (especially for the odd 6 bpp mode).
Reviewed-by: Geert Uytterhoeven geert+renesas@glider.be
I'm taking this in my -next tree[1].
Thanks -- Gustavo
[1] https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git/log/?h=...