On Fri, 2019-05-31 at 14:37 +0200, Neil Armstrong wrote:
Devfreq runtime usage was made mandatory, thus making panfrost fail to probe on Amlogic S912 SoCs missin the "operating-points-v2" property. Make it optional again, leaving PM_DEVFREQ is selected by default.
Fixes: f3617b449d ("drm/panfrost: Select devfreq") Signed-off-by: Neil Armstrong narmstrong@baylibre.com
drivers/gpu/drm/panfrost/panfrost_devfreq.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/panfrost/panfrost_devfreq.c b/drivers/gpu/drm/panfrost/panfrost_devfreq.c index 29fcffdf2d57..dc75f99ad53b 100644 --- a/drivers/gpu/drm/panfrost/panfrost_devfreq.c +++ b/drivers/gpu/drm/panfrost/panfrost_devfreq.c @@ -140,7 +140,9 @@ int panfrost_devfreq_init(struct panfrost_device *pfdev) return 0;
ret = dev_pm_opp_of_add_table(&pfdev->pdev->dev);
- if (ret)
- if (ret == -ENODEV) /* Optional, continue without devfreq */
return 0;- else return ret;
This looks incorrect, should be:
else if (ret) return ret;
Otherwise, if ret == 0, we are bailing out.
Thanks, Eze