Re: [PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map helper function

On Fri, Apr 28, 2017 at 10:53:45AM -0600, Logan Gunthorpe wrote:

On 28/04/17 12:30 AM, Herbert Xu wrote:

...

You are right. Indeed the existing code looks buggy as they don't take sg->offset into account when doing the kmap. Could you send me some patches that fix these problems first so that they can be easily backported?

Ok, I think the only buggy one in crypto is hifn_795x. Shash and caam both do have the sg->offset accounted for. I'll send a patch for the buggy one shortly.

I think they're all buggy when sg->offset is greater than PAGE_SIZE.

Thanks,