Re: [PATCH] drm/exynos: fix error return code in exynos_drm_ipp_set_property()

Hi Wei Yongjun,

On 7 May 2013 18:54, Wei Yongjun weiyj.lk@gmail.com wrote:

From: Wei Yongjun yongjun_wei@trendmicro.com.cn

Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. ipp_create_cmd_work() return ERR_PTR() on error and never return NULL, so use IS_ERR() instead of IS_ERR_OR_NULL().

Signed-off-by: Wei Yongjun yongjun_wei@trendmicro.com.cn

I have submitted a patch [1] to use IS_ERR instead of IS_ERR_OR_NULL() for all incorrect instances in this driver. Please base your patch fixing the return code on top of my patch.

[1] http://lists.freedesktop.org/archives/dri-devel/2013-April/038059.html