Re: [PATCH] drm/amd/pm: use kmemdup() rather than kmalloc+memcpy

Applied. Thanks!

Alex

On Mon, Aug 24, 2020 at 5:33 PM Alex Dewar alex.dewar90@gmail.com wrote:

Issue identified with Coccinelle.

Signed-off-by: Alex Dewar alex.dewar90@gmail.com

.../drm/amd/pm/powerplay/hwmgr/vega20_processpptables.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_processpptables.c b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_processpptables.c index f56a3cbdfa3b..1f9082539457 100644 --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_processpptables.c +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_processpptables.c @@ -890,14 +890,12 @@ static int init_powerplay_table_information( power_saving_clock_count); }

•   pptable_information->smc_pptable = kmalloc(sizeof(PPTable_t), GFP_KERNEL);
  

•   pptable_information->smc_pptable = kmemdup(&(powerplay_table->smcPPTable),
  

•                                              sizeof(PPTable_t),
  

•                                              GFP_KERNEL);
    if (pptable_information->smc_pptable == NULL)
            return -ENOMEM;
  
  

•   memcpy(pptable_information->smc_pptable,
  

•                   &(powerplay_table->smcPPTable),
  

•                   sizeof(PPTable_t));
  

•   result = append_vbios_pptable(hwmgr, (pptable_information->smc_pptable));
    if (result)
  

-- 2.28.0

---

amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx