Re: [PATCH v5 1/3] phy: qcom-edp: add regulator_set_load to edp phy

Quoting Kuogee Hsieh (2022-05-19 10:45:37)

diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c b/drivers/phy/qualcomm/phy-qcom-edp.c index cacd32f..90093cd 100644 --- a/drivers/phy/qualcomm/phy-qcom-edp.c +++ b/drivers/phy/qualcomm/phy-qcom-edp.c @@ -87,14 +87,19 @@ struct qcom_edp {

    struct clk_bulk_data clks[2];
    struct regulator_bulk_data supplies[2];

•   int enable_load[2];
  

};

static int qcom_edp_phy_init(struct phy *phy) { struct qcom_edp *edp = phy_get_drvdata(phy); int ret;

•   int i;
  
  

•   ret = regulator_bulk_enable(ARRAY_SIZE(edp->supplies), edp->supplies);
  

•   for (i = 0; i < 2; i++)
  

•           regulator_set_load(edp->supplies[i].consumer, edp->enable_load[i]);
  

•   ret = regulator_bulk_enable(num_consumers, edp->supplies);
  

Where is num_consumers coming from?

    if (ret)
            return ret;