The git branch bellow is updated.
Changes since v3: - "drm/tilcdc: Enable sync lost error and recovery handling for rev 1 LCDC" - disable sync-lost irq also for rev1 LCDC - LCDC_V1_SYNC_LOST_ENA to LCDC_V1_SYNC_LOST_INT_ENA - "drm/tilcdc: Enable palette loading for revision 2 LCDC too" - disable palette loaded interrupt after receiving it - "drm/tilcdc: Enable frame done irq and functionality for LCDC rev 1" - disable FRAME_DONE interrupt for rev 1 lcdc in interrupt routine - LCDC_V1_FRAME_DONE_ENA to LCDC_V1_FRAME_DONE_INT_ENA - Add: "drm/tilcdc: Configure video mode to HW in enable() not in mode_set_nofb()" - Drop "drm/tilcdc: Use complete_all() to indicate completed palette loading" - Drop "drm/tilcdc: Call reset() before loading the palette" - "drm/tilcdc: Load palette at the end of mode_set_nofb()" - Just load the palette every time, no runtime_resume hook
Changes since v2: - Add: "drm/tilcdc: Fix load mode bit-field setting in tilcdc_crtc_enable()" - Drop: "drm/tilcdc: Free palette dma memory in tilcdc_crtc_destroy()" - Add: "drm/tilcdc: Add timeout wait for palette loading to complete" - Add: "drm/tilcdc: Call reset() before loading the palette" - Add: "drm/tilcdc: Use complete_all() to indicate completed palette loading" - Add "drm/tilcdc: Enable frame done irq and functionality for LCDC rev 1" - Bartosz: Please test if this works! The symptom for not working is "timeout waiting for framedone" message when screen is blanked.
Changes since first version of the series:
- Move tilcdc_regs.h changes from "drm/tilcdc: Enable palette loading for revision 2 LCDC too" to "drm/tilcdc: Add tilcdc_write_mask() to tilcdc_regs.h"
These patches are inspired by this series form Bartosz Golaszewski: https://www.spinics.net/lists/arm-kernel/msg539629.html
The patches are based on drm-next plus the earlier patches that I plan to send in a pull request for 4.10. The base + these patches are pushed here:
https://github.com/jsarha/linux drm-next-tilcdc-for-4.10-wip
Bartosz, please test if this branch works for rev1 LCDC, with your dts file!
Bartosz Golaszewski (1): drm/tilcdc: implement palette loading for rev1
Jyri Sarha (9): drm/tilcdc: Enable sync lost error and recovery handling for rev 1 LCDC drm/tilcdc: Fix tilcdc_crtc_create() return value handling drm/tilcdc: Add tilcdc_write_mask() to tilcdc_regs.h drm/tilcdc: Fix load mode bit-field setting in tilcdc_crtc_enable() drm/tilcdc: Enable palette loading for revision 2 LCDC too drm/tilcdc: Add timeout wait for palette loading to complete drm/tilcdc: Load palette at the end of mode_set_nofb() drm/tilcdc: Configure video mode to HW in enable() not in mode_set_nofb() drm/tilcdc: Enable frame done irq and functionality for LCDC rev 1
drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 558 ++++++++++++++++++++--------------- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 17 +- drivers/gpu/drm/tilcdc/tilcdc_drv.h | 2 +- drivers/gpu/drm/tilcdc/tilcdc_regs.h | 15 + 4 files changed, 344 insertions(+), 248 deletions(-)