Dear Ville
On Jul 2, 2013 8:42 PM, "Ville Syrjälä" ville.syrjala@linux.intel.com wrote:
On Tue, Jul 02, 2013 at 07:59:22PM +0900, Seung-Woo Kim wrote:
From: YoungJun Cho yj44.cho@samsung.com
When drm iommu is not supported, buf->pages has to be allocated and assigned to phys_to_page() result, which type is struct page *. So it is sufficient to allocate buf->pages with multiple struct page pointer size.
Signed-off-by: YoungJun Cho yj44.cho@samsung.com Signed-off-by: Kyungmin Park kyungmin.park@samsung.com
drivers/gpu/drm/exynos/exynos_drm_buf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_buf.c
b/drivers/gpu/drm/exynos/exynos_drm_buf.c
index 22865ba..3200622 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_buf.c +++ b/drivers/gpu/drm/exynos/exynos_drm_buf.c @@ -57,7 +57,7 @@ static int lowlevel_buffer_allocate(struct drm_device
*dev,
dma_addr_t start_addr; unsigned int i = 0;
buf->pages = kzalloc(sizeof(struct page) * nr_pages,
buf->pages = kzalloc(sizeof(struct page *) * nr_pages, GFP_KERNEL);Looks like a prime candidate for kcalloc()
Thank you for nice comments. I had no idea to consider overflow!
I'll update again.
Best regards YJ
if (!buf->pages) { DRM_ERROR("failed to allocate pages.\n");-- 1.7.9.5
dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
-- Ville Syrjälä Intel OTC _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel