Re: [PATCH 4/8]drivers:tmp.c Fix warning: variable 'rc' set but not used

On Mon, 14 Jun 2010 13:26:44 PDT, "Justin P. Mattock" said:

Im getting this warning when compiling: CC drivers/char/tpm/tpm.o drivers/char/tpm/tpm.c: In function 'tpm_gen_interrupt': drivers/char/tpm/tpm.c:508:10: warning: variable 'rc' set but not used

The below patch gets rid of the warning, but I'm not sure if it's the best solution.

rc = transmit_cmd(chip, &tpm_cmd, TPM_INTERNAL_RESULT_SIZE, "attempting to determine the timeouts");

• if (!rc)

• rc = 0;
  

}

Good thing that's a void function. ;)

Unless transmit_cmd() is marked 'must_check', maybe losing the 'rc =' would be a better solution?