Re: [PATCH] gpu: do not double put device node in zx_drm_probe

Ping, Anyone has any objections a about the patch?

Best wishes, zhong jiang On 2018/8/17 10:24, zhong jiang wrote:

for_each_available_child_of_node will get and put the node properly, the following of_node_put will lead to the double put. So just remove it.

Signed-off-by: zhong jiang zhongjiang@huawei.com

drivers/gpu/drm/zte/zx_drm_drv.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/zte/zx_drm_drv.c b/drivers/gpu/drm/zte/zx_drm_drv.c index 6f4205e8..d7b9870 100644 --- a/drivers/gpu/drm/zte/zx_drm_drv.c +++ b/drivers/gpu/drm/zte/zx_drm_drv.c @@ -161,10 +161,8 @@ static int zx_drm_probe(struct platform_device *pdev) if (ret) return ret;

• for_each_available_child_of_node(parent, child) {

• for_each_available_child_of_node(parent, child) component_match_add(dev, &match, compare_of, child);

• of_node_put(child);
  

• }

  return component_master_add_with_match(dev, &zx_drm_master_ops, match);

}