Hi Maxime,
Am 08.07.20 um 19:41 schrieb Maxime Ripard:
Hi everyone,
Here's a (pretty long) series to introduce support in the VC4 DRM driver for the display pipeline found in the BCM2711 (and thus the RaspberryPi 4).
The main differences are that there's two HDMI controllers and that there's more pixelvalve now. Those pixelvalve come with a mux in the HVS that still have only 3 FIFOs. Both of those differences are breaking a bunch of expectations in the driver, so we first need a good bunch of cleanup and reworks to introduce support for the new controllers.
Similarly, the HDMI controller has all its registers shuffled and split in multiple controllers now, so we need a bunch of changes to support this as well.
Only the HDMI support is enabled for now (even though the DPI and DSI outputs have been tested too).
Let me know if you have any comments Maxime
Cc: bcm-kernel-feedback-list@broadcom.com Cc: devicetree@vger.kernel.org Cc: Kamal Dasu kdasu.kdev@gmail.com Cc: linux-clk@vger.kernel.org Cc: Michael Turquette mturquette@baylibre.com Cc: Philipp Zabel p.zabel@pengutronix.de Cc: Rob Herring robh+dt@kernel.org Cc: Stephen Boyd sboyd@kernel.org
Changes from v3:
- Rebased on top of next-20200708
- Added a name to the HDMI audio codec component
- Only disable the BCM2711 HDMI pixelvalves at boot
- Fixed an error in the HVS binding
- Fix a framebuffer size condition that was inverted
- Changed the channel allocation algorithm using Eric's suggestion
- Always write the muxing values instead of updating if needed
- Improved a bit the hvs_available_channels comment in the structure
- Change atomic_complete_commit code to use for_each_new_crtc_in_state
- Change the muxing code to take into account disparities between the BCM2711 and previous SoCs.
- Only change the clock rate on BCM2711 during a modeset
- Fix a crash at atomic_disable
- Use clk_set_min_rate for the core clock too
- Add a few defines, and simplify the FIFO level stuff
- Reordered the patches according to Eric's reviews
- Fixed a regression with VID_CTL setting on RPI3
i additionally applied "drm/vc4/vc4_hdmi: fill ASoC card owner" on top of your series (potential merge conflict).
I didn't see any issues with a RPI 3B or RPI 4B.
So this whole series is
Tested-by: Stefan Wahren stefan.wahren@i2se.com
Regards Stefan