Re: [PATCH v4 2/3] phy/qualcomm: add regulator_set_load to dp phy

On Thu, 19 May 2022 at 00:36, Kuogee Hsieh quic_khsieh@quicinc.com wrote:

This patch add regulator_set_load() before enable regulator at DP phy driver.

Signed-off-by: Kuogee Hsieh quic_khsieh@quicinc.com Reviewed-by: Stephen Boyd swboyd@chromium.org

---

drivers/phy/qualcomm/phy-qcom-qmp.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)

diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c index b144ae1..20ac446 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c @@ -3130,6 +3130,7 @@ struct qmp_phy_cfg { int num_resets; /* regulators to be requested */ const char * const *vreg_list;

•   const unsigned int *vreg_enable_load;
    int num_vregs;
  
    /* array of registers with different offsets */
  

@@ -3346,6 +3347,10 @@ static const char * const qmp_phy_vreg_l[] = { "vdda-phy", "vdda-pll", };

+static const unsigned int qmp_phy_vreg_enable_load[] = {

•   21800, 36000
  

+};

static const struct qmp_phy_cfg ipq8074_usb3phy_cfg = { .type = PHY_TYPE_USB3, .nlanes = 1, @@ -4072,6 +4077,7 @@ static const struct qmp_phy_cfg sm8250_usb3phy_cfg = { .reset_list = msm8996_usb3phy_reset_l, .num_resets = ARRAY_SIZE(msm8996_usb3phy_reset_l), .vreg_list = qmp_phy_vreg_l,

•   .vreg_enable_load       = qmp_phy_vreg_enable_load,
    .num_vregs              = ARRAY_SIZE(qmp_phy_vreg_l),
    .regs                   = qmp_v4_usb3phy_regs_layout,
  
  

@@ -4139,6 +4145,7 @@ static const struct qmp_phy_cfg sm8250_dpphy_cfg = { .reset_list = msm8996_usb3phy_reset_l, .num_resets = ARRAY_SIZE(msm8996_usb3phy_reset_l), .vreg_list = qmp_phy_vreg_l,

•   .vreg_enable_load       = qmp_phy_vreg_enable_load,
    .num_vregs              = ARRAY_SIZE(qmp_phy_vreg_l),
    .regs                   = qmp_v4_usb3phy_regs_layout,
  

I'd ask again: what about the sdm845? SC8180x? SC7180? Do we need to change them too? Currently they will all be handled by the DP driver.

@@ -5008,6 +5015,11 @@ static int qcom_qmp_phy_com_init(struct qmp_phy *qphy) return 0; }

•   if (cfg->vreg_enable_load) {
  

•           for (i = cfg->num_vregs - 1; i >= 0; --i)
  

•                   regulator_set_load(qmp->vregs[i].consumer, cfg->vreg_enable_load[i]);
  

•   }
  

•   /* turn on regulator supplies */
    ret = regulator_bulk_enable(cfg->num_vregs, qmp->vregs);
    if (ret) {
  

-- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project