Re: [PATCH 1/2] Revert "drm/amdgpu: disable runpm if we are the primary adapter"

On 5/4/22 18:50, Alex Deucher wrote:

On Wed, May 4, 2022 at 12:46 PM Javier Martinez Canillas javierm@redhat.com wrote:

...

Hello Alex,

On 5/4/22 15:48, Alex Deucher wrote:

...

This reverts commit b95dc06af3e683d6b7ddbbae178b2b2a21ee8b2b.

This workaround is no longer necessary. We have a better workaround in commit f95af4a9236695 ("drm/amdgpu: don't runtime suspend if there are displays attached (v3)").

I would write this line instead as:

in commit f95af4a9236695 ("drm/amdgpu: don't runtime suspend if there are displays attached (v3)").

When you do it that way checkpatch and some maintainers complain about splitting up a commit line across multiple lines.

It does indeed, how silly. Scratch my comment then.