On Wed, Jan 27, 2021 at 06:26:46PM +0800, Carlis wrote:
From: zhangxuezhi zhangxuezhi1@yulong.com
For st7789v ic,add tearing signal detect to avoid screen tearing
Signed-off-by: zhangxuezhi zhangxuezhi1@yulong.com
v8: delete a log line
drivers/staging/fbtft/fb_st7789v.c | 132 ++++++++++++++++++++++++++++++++++++- drivers/staging/fbtft/fbtft.h | 1 + 2 files changed, 132 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/fbtft/fb_st7789v.c b/drivers/staging/fbtft/fb_st7789v.c index 3a280cc..de7460c 100644 --- a/drivers/staging/fbtft/fb_st7789v.c +++ b/drivers/staging/fbtft/fb_st7789v.c @@ -9,9 +9,12 @@ #include <linux/delay.h> #include <linux/init.h> #include <linux/kernel.h> +#include <linux/mutex.h> +#include <linux/interrupt.h> +#include <linux/completion.h> #include <linux/module.h> #include <video/mipi_display.h>
+#include <linux/gpio/consumer.h> #include "fbtft.h"
#define DRVNAME "fb_st7789v" @@ -66,6 +69,32 @@ enum st7789v_command { #define MADCTL_MX BIT(6) /* bitmask for column address order */ #define MADCTL_MY BIT(7) /* bitmask for page address order */
+#define SPI_PANEL_TE_TIMEOUT 400 +static struct mutex te_mutex;/*mutex for tearing line*/ +static struct completion spi_panel_te;
+static irqreturn_t spi_panel_te_handler(int irq, void *data) +{
- complete(&spi_panel_te);
- return IRQ_HANDLED;
+}
+static void set_spi_panel_te_irq_status(struct fbtft_par *par, bool enable) +{
- static int te_irq_count;
- mutex_lock(&te_mutex);
- if (enable) {
if (++te_irq_count == 1)enable_irq(gpiod_to_irq(par->gpio.te));- } else {
if (--te_irq_count == 0)disable_irq(gpiod_to_irq(par->gpio.te));- }
- mutex_unlock(&te_mutex);
+}
/**
- init_display() - initialize the display controller
@@ -82,6 +111,33 @@ enum st7789v_command { */ static int init_display(struct fbtft_par *par) {
- int rc;
- struct device *dev = par->info->device;
- par->gpio.te = devm_gpiod_get_index_optional(dev, "te", 0, GPIOD_IN);
- if (IS_ERR(par->gpio.te)) {
rc = PTR_ERR(par->gpio.te);pr_err("Failed to request te gpio: %d\n", rc);
You are a driver, always use dev_* calls, not pr_*.
This should be dev_err().
same for other pr_ functions you add in this patch.
Also, look at other commits for this file and make your subject: line match them (i.e. you forgot "staging: ")
thanks,
greg k-h