Re: [PATCH v3 3/3] backlight: lm3630a: add firmware node support

1 May 2019


      Pavel
On 5/1/19 3:26 AM, Pavel Machek wrote:
...
Hi!
...
...
@@ -396,13 +506,20 @@ static int lm3630a_probe(struct i2c_client *client,
   			     GFP_KERNEL);
   	if (pdata == NULL)
   		return -ENOMEM;

/* default values */


pdata->leda_ctrl = LM3630A_LEDA_ENABLE;


pdata->ledb_ctrl = LM3630A_LEDB_ENABLE;




pdata->leda_ctrl = LM3630A_LEDA_DISABLE;


pdata->ledb_ctrl = LM3630A_LEDB_DISABLE;



This is not needed since default is disabled and kzalloc will set these to 0
Let compiler do this kind of optimalizations. Code makes sense as-is.
Yes the code makes sense but it is unnecessary.
Dan
...
							Pavel



    