Den 03.07.2021 21.24, skrev Peter Stuge:
Hi Noralf,
Noralf Trønnes wrote:
Add VID/PID for the Raspberry Pi Pico implementation. Source: https://github.com/notro/gud-pico
+++ b/drivers/gpu/drm/gud/gud_drv.c @@ -660,6 +660,7 @@ static int gud_resume(struct usb_interface *intf)
static const struct usb_device_id gud_id_table[] = { { USB_DEVICE_INTERFACE_CLASS(0x1d50, 0x614d, USB_CLASS_VENDOR_SPEC) },
- { USB_DEVICE_INTERFACE_CLASS(0x16d0, 0x10a9, USB_CLASS_VENDOR_SPEC) }, { }
};
A VID/PID isn't neccessarily tied to one implementation; as long as an implementation is in fact compatible with the driver I consider it okay to reuse a VID/PID, and the 0x1d50 conditions are met by gud-pico too. That said, there's no harm in adding another id. :)
Reviewed-by: Peter Stuge peter@stuge.se
Both patches applied, thanks for reviewing.
Noralf.