Re: [PATCH 08/50] drm/msm: call drm_put_dev directly in ->remove

On Wed, Dec 11, 2013 at 5:34 AM, Daniel Vetter daniel.vetter@ffwll.ch wrote:

The drvdata pointer is already assigned to something useful.

Cc: Rob Clark robdclark@gmail.com Signed-off-by: Daniel Vetter daniel.vetter@ffwll.ch

Reviewed-by: Rob Clark robdclark@gmail.com

---

drivers/gpu/drm/msm/msm_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c index 86537692e45c..aa5f3546bbec 100644 --- a/drivers/gpu/drm/msm/msm_drv.c +++ b/drivers/gpu/drm/msm/msm_drv.c @@ -783,7 +783,7 @@ static int msm_pdev_probe(struct platform_device *pdev)

static int msm_pdev_remove(struct platform_device *pdev) {

•   drm_platform_exit(&msm_driver, pdev);
  

•   drm_put_dev(platform_get_drvdata(pdev));
  
    return 0;
  

}

1.8.4.3