Re: [PATCH v2 25/50] drm/omap: hdmi4: Rework EDID read to isolate data read

Hi,

On 20/08/2019 04:16, Laurent Pinchart wrote:

In preparation of adding DRM bridge support to the hdmi4 encoder code, rework the EDID read to isolate data read.

Signed-off-by: Laurent Pinchart laurent.pinchart@ideasonboard.com

drivers/gpu/drm/omapdrm/dss/hdmi4.c | 94 +++++++++++++++--------- drivers/gpu/drm/omapdrm/dss/hdmi4_core.c | 59 +++------------ drivers/gpu/drm/omapdrm/dss/hdmi4_core.h | 4 +- 3 files changed, 73 insertions(+), 84 deletions(-)

I find this (and the next) patch a bit difficult to review. Can you explain a bit more what the purpose and the change is?

Tomi