Hi Javier,
On Thu, Apr 7, 2022 at 10:03 PM Javier Martinez Canillas javierm@redhat.com wrote:
The current compatible strings for SSD130x I2C controllers contain an -fb suffix, this seems to indicate that are for a fbdev driver. But the DT is supposed to describe the hardware and not Linux implementation details.
Let's deprecate those compatible strings and add a new enum that contains compatible strings that don't have a -fb suffix. These will be matched by the ssd130x-i2c DRM driver.
Signed-off-by: Javier Martinez Canillas javierm@redhat.com
--- a/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml +++ b/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml @@ -12,12 +12,24 @@ maintainers:
properties: compatible:
- enum:
- sinowealth,sh1106-i2c- solomon,ssd1305fb-i2c- solomon,ssd1306fb-i2c- solomon,ssd1307fb-i2c- solomon,ssd1309fb-i2c
- oneOf:
# Deprecated compatible strings- items:- enum:- solomon,ssd1305fb-i2c- solomon,ssd1306fb-i2c- solomon,ssd1307fb-i2c- solomon,ssd1309fb-i2c
Please drop the "-i2c" suffixes, too. We already have plenty of IIO sensors and audio codecs using the same compatible value for spi and i2c, cfr. 'git grep compatible -- "*-[si][p2][ic].c"'
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds