[PATCH 1/3] Add missing "goto out" after fbops->fb_open()

From: Max Staudt mstaudt@suse.de

It doesn't make sense to execute any further actions after a failed call to fbops->fb_open().

Signed-off-by: Max Staudt mstaudt@suse.de --- drivers/video/fbdev/core/fbmem.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/core/fbmem.c b/drivers/video/fbdev/core/fbmem.c index 76c1ad9..913c496 100644 --- a/drivers/video/fbdev/core/fbmem.c +++ b/drivers/video/fbdev/core/fbmem.c @@ -1462,8 +1462,10 @@ __releases(&info->lock) file->private_data = info; if (info->fbops->fb_open) { res = info->fbops->fb_open(info,1); - if (res) + if (res) { module_put(info->fbops->owner); + goto out; + } } #ifdef CONFIG_FB_DEFERRED_IO if (info->fbdefio)