Re: [PATCH v1 1/2] ARM64: dts: qcom: enable eDP panel support for sc7280

Hi,

On Mon, Jan 24, 2022 at 11:04 AM Doug Anderson dianders@chromium.org wrote:

...

+&mdss_edp {

•   status = "okay";
  

•   vdda-1p2-supply = <&vreg_l6b_1p2>;
  

•   vdda-0p9-supply = <&vreg_l10c_0p8>;
  

•   ports {
  

•           port@1 {
  

•                   reg = <1>;
  

•                   edp_out: endpoint {
  

•                           remote-endpoint = <&edp_panel_in>;
  

•                   };
  

•           };
  

•   };
  

I think part of the above should be in sc7280.dtsi. Basically in sc7820.dtsi I think you should have:

ports { #address-cells = <1>; #size-cells = <0>; port@0 { reg = <0>; edp_in: endpoint { remote-endpoint = <&dpu_intf5_out>; }; }; port@1 { reg = <1>; edp_out: endpoint { }; }; };

...and then the crd dts file just needs:

&edp_out { remote-endpoint = <&edp_panel_in>; };

Right?

I've attempted to do the sc7280 part of this in:

https://lore.kernel.org/r/20220202132301.v3.7.Ic84bb69c45be2fccf50e3bd17b845...

Assuming folks think that's good then you should probably base your next version atop that.

-Doug