Re: [PATCH 22/22] drm: rockchip: Add VOP2 driver

Hi Andy,

On Tue, Jan 04, 2022 at 07:07:23PM +0800, Andy Yan wrote:

I thinks we should be very carefully about switch to regmap.

Most of the registers are take effect by frame sync(that is you write the config done bit and when vsync interrupt come),

Not only windows register, but also the SYS_CTRL, post processor(VP0/1/2),  OVERLAY, hdr and so on.

That's why I marked these as nonvolatile, so that reading the registers comes from the cache. I may have missed some registers, these could be added when needed.

...

• ret = vop2_win_init(vop2);
• if (ret)

• return ret;
  

Do you have a count about how much time the function vop2_win_init cost ?

No. Why does that matter?

Sascha