4 Sep
2017
4 Sep
'17
11:18 a.m.
Quoting Maarten Lankhorst (2017-08-30 13:17:48)
The next commit removes the wait for flip_done in in drm_atomic_helper_commit_cleanup_done, but we need it for the tests to pass. Instead of using complicated vblank tracking which ends up being ignored anyway, call the correct atomic helper. :)
RFC because I'm not completely sure what we want to do with the vblank waiting, I think for now this patch is the right way to go until we decide because it preserves the status quo when drm_crtc_commit was introduced.
Fwiw, this is fixing a bug in rotation:
-static bool needs_vblank_wait(struct intel_crtc_state *crtc_state) -{
/* fb updated, need to unpin old fb */if (crtc_state->fb_changed)return true;
is insufficient as the fb may be unchanged but a new vma allocated for the rotated pages. -Chris