Hi Evgeny,
On 26 September 2015 at 22:43, evgeny litvinenko evgeny.v.litvinenko@gmail.com wrote:
Hi Emil,
Including limits.h does seem like the right way forward. Can you send a git format-patch created fix to the ML [1]?
Output of format-patch is at the end of the email.
I added '#include <limits.h>' right before '#include <dirent.h>' because on Debian 8 (jessie) the file dirent.h includes bits/posix1_lim.h which indirectly includes limits.h. Also bits/posix1_lim.h has the comment - 'Never include this file directly; use <limits.h> instead.'
After the patch I built and run make check; make distcheck on Debian - no errors.
Additionally you should have noticed a bunch of warnings (missing implementation of XXX) on non-linux platforms. If you'd like to solve these but you're unsure what exactly the functions are supposed to do, let me know and I can help out. You can also catch me at #dri-devel (freenode), look for xexaxo.
Thanks! Yes I'd like and will try to solve these 'missing implementation', I'll ask you if I have questions.
Glad to hear.
----------------------- Output of format-patch -------------- From 0b491abb893d0faf1a9fe0e3052255bf5ad72592 Mon Sep 17 00:00:00 2001 From: Evgeny Litvinenko evgeny.v.litvinenko@gmail.com Date: Sat, 26 Sep 2015 22:58:15 +0300 Subject: [PATCH] [Bug 92082] Solaris fix: 'PATH_MAX' undeclared
I have applied an identical patch from Felix, hope you don't mind. Mostly because extracting patch fixed with comments is slightly awkward. For the future please use git send-email or paste the contents in your email client (check for wrapping) adding any comments after the --- line.
Thank you Emil