Hi Jagan,
On 04.05.2022 11:16, Jagan Teki wrote:
Hi Marek,
On Tue, Apr 12, 2022 at 3:15 PM Marek Szyprowski m.szyprowski@samsung.com wrote:
Hi Jagan,
On 08.04.2022 18:20, Jagan Teki wrote:
Samsung MIPI DSIM controller is common DSI IP that can be used in various SoCs like Exynos, i.MX8M Mini/Nano.
In order to access this DSI controller between various platform SoCs, the ideal way to incorporate this in the drm stack is via the drm bridge driver.
This patch is trying to differentiate platform-specific and bridge driver code and keep maintaining the exynos_drm_dsi.c code as platform-specific glue code and samsung-dsim.c as a common bridge driver code.
Exynos specific glue code is exynos specific te_irq, host_attach, and detach code along with conventional component_ops.
Samsung DSIM is a bridge driver which is common across all platforms and the respective platform-specific glue will initialize at the end of the probe. The platform-specific operations and other glue calls will invoke on associate code areas.
Updated MAINTAINERS file for this bridge with exynos drm maintainers along with Andrzej as he is the original author.
Tomasz Figa has been not included in MAINTAINERS as he is not available via samsung.com.
v1:
- Don't maintain component_ops in bridge driver
- Don't maintain platform glue code in bridge driver
- Add platform-specific glue code and make a common bridge
Signed-off-by: Jagan Teki jagan@amarulasolutions.com
Well, it took me a while to make this working on Exynos. I'm not really happy of the design, although I didn't spent much time thinking how to improve it and clarify some ambiguities. It doesn't even look that one has compiled the Exynos code after this conversion.
Well, I was successfully built the each commit on exynos and non-exynos
The following changes are needed to get it to the same working state as before this patch (the next patches however break it even further):
commit e358ee6239305744062713c5aa2e8d44f740b81a (HEAD) Author: Marek Szyprowski m.szyprowski@samsung.com Date: Tue Apr 12 11:30:26 2022 +0200
drm: exynos: dsi: fixup driver after conversionWhat exactly it is fixing the existing conversion, could you point that out?
See the diff. Broken build (missing gpio_consumer.h in exynos-dsi), mixed structures put into drvdata (samsung_dsim vs. exynos_dsi) hidden by the casting to void * in the samsung_dsim_host_ops.
Best regards